Skip to content

rust: update msrv to 1.85 - v4 #15111

Closed
jasonish wants to merge 11 commits into
OISF:mainfrom
jasonish:rust-1.8x/v4
Closed

rust: update msrv to 1.85 - v4 #15111
jasonish wants to merge 11 commits into
OISF:mainfrom
jasonish:rust-1.8x/v4

Conversation

@jasonish
Copy link
Copy Markdown
Member

Previous PR: #15060

Rebased.

jasonish added 11 commits March 26, 2026 13:04
Don't install extra repo's in the script, do it in CI. These are covered
by the documentation as they vary depending on the version and variant.
Debian 13 ships Rust 1.85 by default, Ubuntu requires installing a
specific patch to get newer then 1.75. So to support a newer MSRV,
these operating systems need different examples.
1.85 was chosen for now as it supports edition 2024. However, we have
not set our edition to 2024 yet.
Disable the clippy warning for not using modern C string
literals. Ubuntu 24.04 still ships cbindgen 0.26.0 that doesn't
support these, so migrating to modern C string literals would require
Ubuntu 24.04 users wishing to build from git to install cbindgen with
cargo.
To pick up a newer version of Rust.
@jasonish jasonish requested review from a team and jufajardini as code owners March 26, 2026 19:05
@suricata-qa
Copy link
Copy Markdown

WARNING:
ERROR: buid failure for build_asan QA build

field baseline test %
build_asan

Pipeline = 30572

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.60%. Comparing base (dce2dee) to head (a6e1027).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15111      +/-   ##
==========================================
- Coverage   82.63%   82.60%   -0.03%     
==========================================
  Files         990      990              
  Lines      271599   271599              
==========================================
- Hits       224429   224357      -72     
- Misses      47170    47242      +72     
Flag Coverage Δ
fuzzcorpus 61.06% <ø> (-0.01%) ⬇️
livemode 18.34% <ø> (-0.05%) ⬇️
netns 18.34% <ø> (-0.06%) ⬇️
pcap 45.23% <ø> (-0.06%) ⬇️
suricata-verify 66.14% <ø> (-0.04%) ⬇️
unittests 58.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@catenacyber
Copy link
Copy Markdown
Contributor

What is the plan for QA update ?

@victorjulien
Copy link
Copy Markdown
Member

What is the plan for QA update ?

As discussed privately, Corey will prep a rebaseline like over the weekend.

@victorjulien
Copy link
Copy Markdown
Member

Waiting for @ct0br0 to prep the QAlab.

@catenacyber
Copy link
Copy Markdown
Contributor

Looks cool

Is there a follow-up work to clean up things that were restricted by MSRV ?
Like // Allow unknown lints, our MSRV doesn't know them all in rust/htp/src/lib.rs

@jasonish
Copy link
Copy Markdown
Member Author

jasonish commented Apr 3, 2026

Looks cool

Is there a follow-up work to clean up things that were restricted by MSRV ? Like // Allow unknown lints, our MSRV doesn't know them all in rust/htp/src/lib.rs

None yet. This was just a feeler to see if we were even ready to up the MSRV.

@jasonish
Copy link
Copy Markdown
Member Author

jasonish commented Apr 6, 2026

Replaced by #15167

@jasonish jasonish closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants