rust: update msrv to 1.85 - v5 #15167
Closed
jasonish wants to merge 12 commits into
Closed
Conversation
Don't install extra repo's in the script, do it in CI. These are covered by the documentation as they vary depending on the version and variant.
Debian 13 ships Rust 1.85 by default, Ubuntu requires installing a specific patch to get newer then 1.75. So to support a newer MSRV, these operating systems need different examples.
1.85 was chosen for now as it supports edition 2024. However, we have not set our edition to 2024 yet.
Disable the clippy warning for not using modern C string literals. Ubuntu 24.04 still ships cbindgen 0.26.0 that doesn't support these, so migrating to modern C string literals would require Ubuntu 24.04 users wishing to build from git to install cbindgen with cargo.
To pick up a newer version of Rust.
This is required when rustc is not in a standard path. The other cbindgen calls already had this, so it was just missed while adding the ffi bindings, but shows up when rustc is at a path like /usr/lib/rust-1.89/bin/rustc, but that directory is not in your path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15167 +/- ##
=======================================
Coverage 82.71% 82.72%
=======================================
Files 993 993
Lines 271737 271737
=======================================
+ Hits 224772 224782 +10
+ Misses 46965 46955 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 30816 |
1 similar comment
|
Information: QA ran without warnings. Pipeline = 30816 |
Contributor
|
I guess it is ok, do not we use a ticket for this work ? |
Member
|
FYI I'm working through supporting this in my own CI, w/o it affecting <9. |
Member
Author
|
Replaced by #15328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased.