unittests: convert util-spm tests to FAIL/PASS API#15336
unittests: convert util-spm tests to FAIL/PASS API#153360x-0ddc0de wants to merge 1 commit intoOISF:mainfrom
Conversation
|
NOTE: This PR may contain new authors. |
|
Code and commit message looking ok, allowing CI checks to run. The tests clean-up could have maybe minor optimizations, but not mandatory for this patch, imho. |
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The check about code formatting means that you'll have to run clang-format locally, to fix that:
./scripts/clang-format.sh check-branch
If this results in too many changes, especially touching areas of the file you didn't work on, please keep them in a separate commit, to make it easier to review.
Please submit a new PR with that, and make sure that you use the same email address used when you signed the Contribution Agreement to sign your commit message! :)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15336 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 993 995 +2
Lines 271004 271031 +27
==========================================
+ Hits 224022 224043 +21
- Misses 46982 46988 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2 participants
Most old printf statements for failing conditions were removed during the FAIL/PASS conversion. I kept the printfs in the nested offset-search loops because a bare FAIL_IF would only identify the failing line, not the specific needle/text/offset combination that failed.
Issue: 6334