Redmine 6334 v2#15341
Conversation
| if (found == 0) { | ||
| printf("Error1 searching for %s in text %s\n", needle[i], text[i][j]); | ||
| return 0; | ||
| FAIL; |
There was a problem hiding this comment.
the expectation here is to replace the whole if (found == 0) { ... block with a single FAIL_IF(found == 0);
There was a problem hiding this comment.
Sure I can do that. I had originally considered doing just as you described; however, it seemed that removing the printf makes it hard to trace down which specific subcase was failing, which is why I left the printf.
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Would like to see the no-branch idea followed through more thoroughly. Also make sure to not create multiple commits that are having the exact same text. In this case I would expect a single commit.
|
NOTE: This PR may contain new authors. |
Done. My v3 PR squashes into a single commit. I had misunderstood the docs on this, as it described creating a new PR for each revision. |
|
Replaced by: #15368 Didn't investigate the CI failures. Maybe missing a rebase? |
4 participants
Update to address comments on Previous PR. Ran clang-format.
Issue: 6334