detect/dcerpc: avoids FP on dcerpc.iface keyword#15355
Merged
Merged
Conversation
When we got a bind without the first fragment flag, and did not set any_frag in the signature, the signature always matched, whatever the uuid value Ticket: 8457 (cherry picked from commit e388888)
victorjulien
approved these changes
May 10, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #15355 +/- ##
==============================================
+ Coverage 81.62% 81.63% +0.01%
==============================================
Files 1012 1012
Lines 275230 275226 -4
==============================================
+ Hits 224655 224689 +34
+ Misses 50575 50537 -38
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 31343 |
inashivb
reviewed
May 11, 2026
| if !detect_match_uint(x, uuidentry.version) { | ||
| SCLogDebug!("Interface version did not match"); | ||
| ret &= 0; | ||
| continue |
Member
There was a problem hiding this comment.
wow I didn't know statements were acceptable without semicolon
Member
There was a problem hiding this comment.
or does it take it as a return statement and do something funky?
Member
|
Merged in #15359, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8522
Describe changes:
SV_BRANCH=OISF/suricata-verify#3077