Skip to content

detect/dcerpc: avoids FP on dcerpc.iface keyword #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victorjulien merged 1 commit into from
May 11, 2026
+9 −11
Merged

detect/dcerpc: avoids FP on dcerpc.iface keyword #15355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions rust/src/dcerpc/detect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,50 +62,48 @@ pub struct DCEOpnumData {
fn match_backuuid(
tx: &DCERPCTransaction, state: &mut DCERPCState, if_data: &mut DCEIfaceData,
) -> u8 {
let mut ret = 0;
if !state.interface_uuids.is_empty() {
for uuidentry in &state.interface_uuids {
ret = 1;
// if any_frag is not enabled, we need to match only against the first fragment
if if_data.any_frag == 0 && (uuidentry.flags & DCERPC_UUID_ENTRY_FLAG_FF == 0) {
SCLogDebug!("any frag not enabled");
continue;
}
// if the uuid has been rejected(uuidentry->result == 1), we skip to the next uuid
if !uuidentry.acked || uuidentry.result != 0 {
ret = 0;
SCLogDebug!("Skipping to next UUID");
continue;
}

let mut same = true;
for i in 0..16 {
if if_data.if_uuid[i] != uuidentry.uuid[i] {
SCLogDebug!("Iface UUID and BINDACK Accepted UUID does not match");
ret = 0;
same = false;
break;
}
}
if !same {
continue;
}
let ctxid = tx.get_req_ctxid();
ret &= (uuidentry.ctxid == ctxid) as u8;
if ret == 0 {
if uuidentry.ctxid != ctxid {
SCLogDebug!("CTX IDs/UUIDs do not match");
continue;
}

if let Some(x) = &if_data.du16 {
if !detect_match_uint(x, uuidentry.version) {
SCLogDebug!("Interface version did not match");
ret &= 0;
continue
Copy link
Copy Markdown
Member

@inashivb inashivb May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I didn't know statements were acceptable without semicolon

Copy link
Copy Markdown
Member

@inashivb inashivb May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or does it take it as a return statement and do something funky?

}
}

if ret == 1 {
return 1;
}
return 1;
}
}

return ret;
return 0;
}

fn parse_iface_data(arg: &str) -> Result<DCEIfaceData, ()> {
Expand Down
Loading