Skip to content

build: solaris porting changes - #15513

Closed
l1gi wants to merge 1 commit into
OISF:mainfrom
l1gi:solaris-7005-v2
Closed

build: solaris porting changes#15513
l1gi wants to merge 1 commit into
OISF:mainfrom
l1gi:solaris-7005-v2

Conversation

@l1gi

@l1gi l1gi commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Ticket: 7005

Description:

This updates the Solaris porting changes on top of current upstream main.

Changes include:

  • guarding DT_* / dirent usage where not available
  • using __sun and Solaris byteorder helpers
  • avoiding tm_gmtoff access on Solaris
  • guarding LOG_FTP
  • enabling SPARC misalignment emulation
  • guarding RLIMIT_NPROC

@l1gi
l1gi requested a review from victorjulien as a code owner June 2, 2026 12:07
@l1gi l1gi mentioned this pull request Jun 2, 2026
3 tasks
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

NOTE: This PR may contain new authors.

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.77%. Comparing base (9e82ff8) to head (e1a290f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15513      +/-   ##
==========================================
- Coverage   82.77%   82.77%   -0.01%     
==========================================
  Files         999      999              
  Lines      272666   272667       +1     
==========================================
- Hits       225700   225691       -9     
- Misses      46966    46976      +10     
Flag Coverage Δ
fuzzcorpus 61.43% <18.18%> (-0.01%) ⬇️
livemode 18.28% <63.63%> (-0.04%) ⬇️
netns 22.74% <9.09%> (+<0.01%) ⬆️
pcap 44.91% <18.18%> (-0.05%) ⬇️
suricata-verify 66.42% <45.45%> (-0.03%) ⬇️
unittests 58.40% <36.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@catenacyber

Copy link
Copy Markdown
Contributor

Why did you come from the 6 separated commits in #15092 to one ?

See #15092 (comment) (I had missed this)

@l1gi

l1gi commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Why did you come from the 6 separated commits in #15092 to one ?

See #15092 (comment) (I had missed this)

Because someone in previous ticket asked me to do that.

@catenacyber

Copy link
Copy Markdown
Contributor

There was a misunderstanding :

It is better to have 6 commits as Victor said in #15092 (comment)

@l1gi

l1gi commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Do I understand correctly, there is no action needed from my side right now, please?

@catenacyber

Copy link
Copy Markdown
Contributor

Do I understand correctly, there is no action needed from my side right now, please?

Incorrect : please do a new PR with 6 commits as Victor said in #15092 (comment)

@l1gi

l1gi commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by: #15576

I reopened this as a new PR with the original 6-commit series on top of current upstream main.

The new PR is:
#15576

@catenacyber

Copy link
Copy Markdown
Contributor

Thanks, closing in favor of #15576

@catenacyber catenacyber closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants