Skip to content

Solaris porting changes. - #15092

Closed
l1gi wants to merge 6 commits into
OISF:mainfrom
l1gi:main
Closed

Solaris porting changes.#15092
l1gi wants to merge 6 commits into
OISF:mainfrom
l1gi:main

Conversation

@l1gi

@l1gi l1gi commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Ticket: 7005

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7005

Describe changes:

@l1gi
l1gi requested a review from victorjulien as a code owner March 24, 2026 13:46
@l1gi l1gi mentioned this pull request Mar 24, 2026
3 tasks
@github-actions

Copy link
Copy Markdown

NOTE: This PR may contain new authors.

@catenacyber

Copy link
Copy Markdown
Contributor

Argh, I guess it will need a rebase to get green CI

@victorjulien

Copy link
Copy Markdown
Member

I'd like to see this split out into different commits, not just a general "Solaris porting changes". Essentially the list of changes in the PR message body has the logical separation I think would be appropriate for the commits. Esp the alignment commit would need to have a bit more explanation of what it does and why.

@victorjulien victorjulien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good, git needs to a cleanup.

Also needs a rebase again.

@l1gi

l1gi commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi Victor,

so could you help me and list what exact steps should I do to make all this pass? I have done the rebase twice without success. Did I something wrong, please?

Sorry, I am not keen on github development, but I still would like to make these change to get to the repo.

Regards,
m.

@catenacyber

Copy link
Copy Markdown
Contributor

You need to do something like

git fetch
git rebase origin/main 
git checkout -b solaris-7005-v2
git push yourrepo

And then create a new PR

Also have the commit message have a title like build: solaris porting changes

See https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html

l1gi added 6 commits June 2, 2026 13:53
Guard DT_REG usage so directory walking code still builds on platforms where dirent does not expose d_type or DT_REG, such as Solaris.
Replace uses of the non-standard sun macro with __sun and use Solaris byte swap helpers from <sys/byteorder.h>. This keeps the Solaris-specific code paths reachable when building with standard-conforming toolchains.
Skip tm_gmtoff and tm_zone initialization on Solaris where those struct tm members are not available.
Only expose the ftp facility when the platform syslog headers define LOG_FTP.
Call a SPARC-specific helper during pre-init so the kernel emulates unaligned accesses for this process instead of terminating on alignment faults. This matches the Solaris/SPARC portability fix that motivated the original patch.
Only use RLIMIT_NPROC when the platform exposes that resource limit constant.
@l1gi

l1gi commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

I rebased this work onto current upstream main, squashed it into a single commit as requested, and opened a new PR with the updated branch.

Superseded by: #15513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants