Solaris porting changes v3 - #15576
Closed
l1gi wants to merge 6 commits into
Closed
Conversation
Guard DT_REG usage so directory walking code still builds on platforms where dirent does not expose d_type or DT_REG, such as Solaris.
Replace uses of the non-standard sun macro with __sun and use Solaris byte swap helpers from <sys/byteorder.h>. This keeps the Solaris-specific code paths reachable when building with standard-conforming toolchains.
Skip tm_gmtoff and tm_zone initialization on Solaris where those struct tm members are not available.
Only expose the ftp facility when the platform syslog headers define LOG_FTP.
Call a SPARC-specific helper during pre-init so the kernel emulates unaligned accesses for this process instead of terminating on alignment faults. This matches the Solaris/SPARC portability fix that motivated the original patch.
Only use RLIMIT_NPROC when the platform exposes that resource limit constant.
|
NOTE: This PR may contain new authors. |
victorjulien
approved these changes
Jun 10, 2026
Merged
Member
|
Merged in #15601, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Solaris porting changes on top of current upstream main as a small series of logical
commits instead of a single squashed patch.
The series includes:
util/path: handle missingd_type/DT_REGdefinitionsbuild/solaris: use__sunand Solaris byteorder helpersutil/time: avoidtm_gmtoffon Solarisutil/syslog: guardLOG_FTPutil/cpu: enable SPARC misalignment emulation at startupsuricata: guardRLIMIT_NPROCusageTicket: 7005