rust: format dcerpc files - #15645
Merged
Merged
Conversation
Ticket: 3836
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15645 +/- ##
=======================================
Coverage 82.90% 82.91%
=======================================
Files 1006 1006
Lines 273648 273680 +32
=======================================
+ Hits 226869 226918 +49
+ Misses 46779 46762 -17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline = 32036 |
Member
Seems unrelated. |
|
Information: QA ran without warnings. Pipeline = 32037 |
victorjulien
approved these changes
Jun 15, 2026
victorjulien
left a comment
victorjulien
left a comment
Member
There was a problem hiding this comment.
Minor nit, lets fix that later.
| let tx = &self.transactions[i]; | ||
| if tx.id == tx_id { //+ 1 { | ||
| if tx.id == tx_id { | ||
| //+ 1 { |
Merged
Member
|
Merged in #15659, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/3836
Describe changes:
#15616 next round
Still TODO the biggest ones: base dir, smb