Rust fmt 3836 v10 - #15660
Conversation
|
base dir has a smaller diff than this one |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15660 +/- ##
========================================
Coverage 82.91% 82.92%
========================================
Files 1006 1006
Lines 273690 274476 +786
========================================
+ Hits 226942 227616 +674
- Misses 46748 46860 +112
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 32087 |
| let x = if dcer.little_endian { | ||
| vec![i.iface[3], i.iface[2], i.iface[1], i.iface[0], | ||
| i.iface[5], i.iface[4], i.iface[7], i.iface[6], | ||
| i.iface[8], i.iface[9], i.iface[10], i.iface[11], |
There was a problem hiding this comment.
wish this had a comment about why the initial bytes are specifically ordered, but then the later ones are just 8 to 11. Intentional? No idea :-/
There was a problem hiding this comment.
I think it is intentional : uuids are strangely encoded :
When you have
5d2b62aa-ee0a-4a95-91ae-b064fdb471fc
On the wire, it shows up as
aa622b5d0aee954a91aeb064fdb471fc
See dcerpc-issue-7187-01/test.pcap
| let buff:&[u8] = &[ | ||
| /* message type */ 0x00, | ||
| /* length */ 0x00, 0x00, 0x55, | ||
| /* data */ 0xff, 0x53, 0x4d, 0x42, 0x72, 0x00, 0x00, 0x00, 0x00, | ||
| 0x98, 0x53, 0xc8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, | ||
| 0xfe, 0x00, 0x00, 0x00, 0x00, 0x11, 0x05, 0x00, 0x03, | ||
| 0x0a, 0x00, 0x01, 0x00, 0x04, 0x11, 0x00, 0x00, 0x00, | ||
| 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfd, 0xe3, | ||
| 0x00, 0x80, 0x2a, 0x55, 0xc4, 0x38, 0x89, 0x03, 0xcd, | ||
| 0x01, 0x2c, 0x01, 0x00, 0x10, 0x00, 0xfe, 0x82, 0xf1, | ||
| 0x64, 0x0b, 0x66, 0xba, 0x4a, 0xbb, 0x81, 0xe1, 0xea, | ||
| 0x54, 0xae, 0xb8, 0x66]; | ||
| let buff: &[u8] = &[ | ||
| /* message type */ 0x00, /* length */ 0x00, 0x00, 0x55, /* data */ 0xff, | ||
| 0x53, 0x4d, 0x42, 0x72, 0x00, 0x00, 0x00, 0x00, 0x98, 0x53, 0xc8, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xfe, 0x00, | ||
| 0x00, 0x00, 0x00, 0x11, 0x05, 0x00, 0x03, 0x0a, 0x00, 0x01, 0x00, 0x04, 0x11, 0x00, | ||
| 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfd, 0xe3, 0x00, 0x80, 0x2a, | ||
| 0x55, 0xc4, 0x38, 0x89, 0x03, 0xcd, 0x01, 0x2c, 0x01, 0x00, 0x10, 0x00, 0xfe, 0x82, | ||
| 0xf1, 0x64, 0x0b, 0x66, 0xba, 0x4a, 0xbb, 0x81, 0xe1, 0xea, 0x54, 0xae, 0xb8, 0x66, | ||
| ]; |
There was a problem hiding this comment.
Maybe an ignore around this hand formatting for readability?
There was a problem hiding this comment.
guess if someone would really inspect it they'd reformat it? Was planning to approve and stage, but can hold off.
There was a problem hiding this comment.
Its easy enough to "reverse" still.
|
Merged in #15663, thanks! |
4 participants
Link to ticket: https://redmine.openinfosecfoundation.org/issues/3836
Describe changes:
Do not format the file smb_status.rs with its big list
#15645 next round
Still TODO the last one: base dir