Windows quote 8600 backport7 - #15681
Closed
catenacyber wants to merge 2 commits into
Closed
Conversation
Ticket: 8600 CreateServiceA doc states for example : > If the path contains a space, it must be quoted so that it is correctly interpreted. Also fixes strlcat usage and check return value to error out on truncated path (cherry picked from commit ac1b3cc)
to deal with the failure due to cbindgen updates and mismatches in
generated bindings.
detect-bytemath.c:61: error: "DETECT_BYTEMATH_ENDIAN_DEFAULT" redefined [-Werror]
61 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT (uint8_t) BigEndian
|
In file included from rust.h:34,
from detect-bytemath.c:32:
./../rust/gen/rust-bindings.h:5071: note: this is the location of the previous definition
5071 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT BigEndian
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #15681 +/- ##
==============================================
- Coverage 81.52% 81.52% -0.01%
==============================================
Files 925 925
Lines 252965 252965
==============================================
- Hits 206235 206227 -8
- Misses 46730 46738 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 32168 |
jufajardini
approved these changes
Jun 19, 2026
jufajardini
left a comment
jufajardini
left a comment
Contributor
There was a problem hiding this comment.
Looks consistent with what was approved for 8, and CI checks pass.
victorjulien
approved these changes
Jun 21, 2026
Member
|
Merged in #15694, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8600
Describe changes: