Skip to content

next/1402/70x/20260622/v1 - #15694

Merged
victorjulien merged 4 commits into
OISF:main-7.0.xfrom
victorjulien:next/1402/70x/20260622/v1
Jun 22, 2026
Merged

next/1402/70x/20260622/v1#15694
victorjulien merged 4 commits into
OISF:main-7.0.xfrom
victorjulien:next/1402/70x/20260622/v1

Conversation

@victorjulien

Copy link
Copy Markdown
Member

inashivb and others added 4 commits June 18, 2026 12:01
to deal with the failure due to cbindgen updates and mismatches in
generated bindings.

detect-bytemath.c:61: error: "DETECT_BYTEMATH_ENDIAN_DEFAULT" redefined [-Werror]
   61 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT (uint8_t) BigEndian
      |
In file included from rust.h:34,
                 from detect-bytemath.c:32:
./../rust/gen/rust-bindings.h:5071: note: this is the location of the previous definition
 5071 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT BigEndian
      |
Ticket: 8600

CreateServiceA doc states for example :

> If the path contains a space, it must be quoted so that it is
  correctly interpreted.

Also fixes strlcat usage and check return value to error out on
truncated path

(cherry picked from commit ac1b3cc)
Ticket: 8634
(cherry picked from commit 097975e)
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.52%. Comparing base (6e7907e) to head (3dc8217).
⚠️ Report is 4 commits behind head on main-7.0.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #15694      +/-   ##
==============================================
- Coverage       81.52%   81.52%   -0.01%     
==============================================
  Files             925      925              
  Lines          252965   252980      +15     
==============================================
+ Hits           206235   206240       +5     
- Misses          46730    46740      +10     
Flag Coverage Δ
fuzzcorpus 62.22% <100.00%> (-0.04%) ⬇️
suricata-verify 63.85% <100.00%> (+0.04%) ⬆️
unittests 62.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.ftp-data 604 560 92.72%

Pipeline = 32190

@victorjulien
victorjulien merged commit 3dc8217 into OISF:main-7.0.x Jun 22, 2026
51 checks passed
@victorjulien
victorjulien deleted the next/1402/70x/20260622/v1 branch June 22, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants