Skip to content

Comments

Http uri spaces 2881 v16#8509

Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:http-uri-spaces-2881-v16
Closed

Http uri spaces 2881 v16#8509
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:http-uri-spaces-2881-v16

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #8494 with needed rebase

suricata-verify-pr: 1004

OISF/suricata-verify#1004

@catenacyber catenacyber added this to the 8.0 milestone Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #8509 (620d397) into master (3247e39) will decrease coverage by 0.26%.
The diff coverage is 83.33%.

❗ Current head 620d397 differs from pull request most recent head 77ef39f. Consider uploading reports for the commit 77ef39f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8509      +/-   ##
==========================================
- Coverage   82.30%   82.04%   -0.26%     
==========================================
  Files         969      967       -2     
  Lines      273335   278361    +5026     
==========================================
+ Hits       224960   228387    +3427     
- Misses      48375    49974    +1599     
Flag Coverage Δ
fuzzcorpus 64.27% <83.33%> (-0.33%) ⬇️
suricata-verify 59.93% <77.77%> (-0.49%) ⬇️
unittests 63.35% <22.22%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 12214

@catenacyber catenacyber removed this from the 8.0 milestone Apr 3, 2023
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 12214

@catenacyber catenacyber added this to the 8.0 milestone May 18, 2023
@catenacyber catenacyber added the needs rebase Needs rebase to main label May 18, 2023
@catenacyber catenacyber removed the needs rebase Needs rebase to main label May 18, 2023
@catenacyber catenacyber force-pushed the http-uri-spaces-2881-v16 branch from 620d397 to 77ef39f Compare May 18, 2023 17:49
@suricata-qa
Copy link

ERROR:
ERROR: ASAN TEST FAIL in ASAN_TLPR1_cfg QA test

ERROR: QA failed on ASAN_TLPR1_cfg.

Pipeline 13839

@catenacyber
Copy link
Contributor Author

Replaced by #8923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants