Closed
Conversation
catenacyber
requested review from
a team,
jufajardini and
victorjulien
as code owners
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 14046 |
jlucovsky
reviewed
May 28, 2023
| - IPS users: by default various new "exception policies" are set to DROP | ||
| traffic. Please see :ref:`Exception Policies <exception policies>` for details | ||
| on the settings and their scope. | ||
| - Spaces are accepted in HTTP1 URIs instead of in the protocol version. That is: |
Contributor
There was a problem hiding this comment.
Suggest rewording this for clarification purposes.
Contributor
Author
There was a problem hiding this comment.
How would you make it clearer ? cc @jufajardini
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 14046 |
Contributor
Author
|
Rebased in #9422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881
Describe changes:
Modifies #8509 with fixing
DetectHttpProtocolValidateCallbackto use new s->init_data->buffer_index like others validators have been updatedsuricata-verify-pr: 1004
OISF/suricata-verify#1004