Closed
Conversation
For probing parsers used with a pattern, restrict the max depth to these probing parsers and not all probing parsers. Finishing protocol detection earlier allows to parse data earlier in the case we recognize only one side.
When an app-layer is recognized for one side, but the other is still unknown, and the parsing of the one side errors, it disables app-layer, and thus the ending pseudo-packets do not get a chance to conclude for app-layer detection on the unknown side. So count in stats the app-layer protocol that was recognized the first time.
When probing parser is only tried from one recognized side of the protocol, even if this parser failed, it never set probing parser done as no mask were used.
|
WARNING:
Pipeline 12216 |
so as to allow ' in github discussion and get CI green
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8512 +/- ##
==========================================
+ Coverage 81.84% 82.01% +0.17%
==========================================
Files 967 967
Lines 278343 278451 +108
==========================================
+ Hits 227799 228369 +570
+ Misses 50544 50082 -462
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 12239 |
Contributor
Author
|
TODO : investigate QA ftp diff |
Contributor
Author
|
Replaced by #8696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/1125
Describe changes:
The most special trick is that the (server) probing parser waits for the client side to have seen some data to take a definitive positive decision.
So that If it looks like a SMTP server (it could be a FTP server), let's see if the client looks like SMTP or FTP or something unknown...
Modifies #8448 by
QA results analysis :
Draft :
I think this PR should be split
But the generic protocol detection bugs only make a difference (as far as I know) when adding the legit SMTP/FTP probing parsers
What are your thoughts on this ?