Closed
Conversation
For probing parsers used with a pattern, restrict the max depth to these probing parsers and not all probing parsers. Finishing protocol detection earlier allows to parse data earlier in the case we recognize only one side.
When an app-layer is recognized for one side, but the other is still unknown, and the parsing of the one side errors, it disables app-layer, and thus the ending pseudo-packets do not get a chance to conclude for app-layer detection on the unknown side. So count in stats the app-layer protocol that was recognized the first time.
When probing parser is only tried from one recognized side of the protocol, even if this parser failed, it never set probing parser done as no mask were used.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8696 +/- ##
==========================================
- Coverage 81.86% 81.85% -0.01%
==========================================
Files 968 968
Lines 279018 279042 +24
==========================================
- Hits 228419 228416 -3
- Misses 50599 50626 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 13059 |
Contributor
Author
|
@ct0br0 how can we confirm that the QA ftp changes are related to in fact pop3 ? |
|
After taking a look at TLPW1 it looks like POP3 counters aren't incremented at all? I'll send you a link with ftp+data/email pcaps. |
Contributor
Author
|
Thanks Corey, continuing in #8804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/1125 preliminary work
Describe changes:
Modifies #8512 by only taking some commits
Draft : waiting for QA