http: logs custom headers in a subobject#8714
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
http: logs custom headers in a subobject#8714catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
This subobject is request_headers or response_headers This especially avoids json keys collisions. Ticket: OISF#5320 Also fixes typo referrer/referer
Contributor
Author
|
WARNING:
Pipeline 13113 |
victorjulien
approved these changes
May 18, 2023
jasonish
approved these changes
May 23, 2023
Merged
Merged
Member
|
Merged in #8951, thanks! I think this needs an upgrade doc entry still btw. |
Contributor
Author
|
Indeed, see #8978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5320
Describe changes:
To avoid collisions, for instance for
content_rangeWith this PR, the output will be
instead of
response_headersis already used with the config optiondump-all-headerssuricata-verify-pr: 1026
Replaces #8672 with better code style for a variable name