Merged
Conversation
A workflow dispatch allows us to manually a trigger a workflow with arguments. This dispatch allows us to use the "gh" cli command to trigger a workflow run with our libhtp/su/sv branch and repo variables set. For example: gh run builds.yml -f SV_REPO=jasonish/suricata-verify -f SV_BRANCH=pr/10
This subobject is request_headers or response_headers This especially avoids json keys collisions. Ticket: OISF#5320 Also fixes typo referrer/referer
Issue drop to packet as early as possible.
Now that flow drop is applied to packets before other processing, no drop has to be issued on a packet.
Remove logic to apply flow drop, as this is now handled in the flow engine. However, keep the logic that frees/cleans the session state.
When a flow is in the drop flow state, don't use pseudo packets when it is timing out. There should be no work left to do at this point.
Test broke after recent changes. Functionality is tested in suricata-verify, so just remove the test.
Merged
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8951 +/- ##
=======================================
Coverage 82.39% 82.40%
=======================================
Files 969 969
Lines 273558 273476 -82
=======================================
- Hits 225404 225346 -58
+ Misses 48154 48130 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information:
Pipeline 14195 |
Merged
This was referenced Jun 5, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=pr/1224