Skip to content

Comments

Mqtt frames v9#8730

Closed
hsadia538 wants to merge 2 commits intoOISF:masterfrom
hsadia538:mqtt-frames-v9
Closed

Mqtt frames v9#8730
hsadia538 wants to merge 2 commits intoOISF:masterfrom
hsadia538:mqtt-frames-v9

Conversation

@hsadia538
Copy link
Contributor

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5731

Previous PR: #8540

Describe new changes:

  • Remove trunc.data frames to cater for truncated packets

suricata-verify-pr: 1172

Adds PDU, Header and Data frame to the MQTT parser.
Ticket: 5731
@hsadia538 hsadia538 requested a review from jasonish as a code owner April 15, 2023 20:04
This was referenced Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #8730 (607d809) into master (6bc7f02) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8730      +/-   ##
==========================================
- Coverage   81.96%   81.86%   -0.10%     
==========================================
  Files         969      969              
  Lines      279163   279203      +40     
==========================================
- Hits       228802   228576     -226     
- Misses      50361    50627     +266     
Flag Coverage Δ
fuzzcorpus 64.32% <97.91%> (-0.20%) ⬇️
suricata-verify 59.82% <100.00%> (+<0.01%) ⬆️
unittests 63.23% <4.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien self-assigned this May 5, 2023
This was referenced May 30, 2023
@victorjulien
Copy link
Member

Merged in #8945, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants