Skip to content

Comments

github-ci: add workflow_dispatch#8878

Closed
jasonish wants to merge 1 commit intoOISF:masterfrom
jasonish:github-ci/workflow-dispatch/v1
Closed

github-ci: add workflow_dispatch#8878
jasonish wants to merge 1 commit intoOISF:masterfrom
jasonish:github-ci/workflow-dispatch/v1

Conversation

@jasonish
Copy link
Member

A workflow dispatch allows us to manually a trigger a workflow with
arguments. This dispatch allows us to use the "gh" cli command to
trigger a workflow run with our libhtp/su/sv branch and repo variables
set. For example:

gh run builds.yml -f SV_REPO=jasonish/suricata-verify -f SV_BRANCH=pr/10

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #8878 (d1c6b66) into master (ebe0a7b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d1c6b66 differs from pull request most recent head d6cf757. Consider uploading reports for the commit d6cf757 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8878   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         969      969           
  Lines      273335   273240   -95     
=======================================
- Hits       224961   224902   -59     
+ Misses      48374    48338   -36     
Flag Coverage Δ
fuzzcorpus 64.61% <ø> (-0.04%) ⬇️
suricata-verify 60.38% <ø> (-0.07%) ⬇️
unittests 62.95% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, how did you test it ?

@jasonish
Copy link
Member Author

Looks good to me, how did you test it ?

Push it to my own master then running something like:

gh -R jasonish/suricata workflow run builds.yml -f SV_REPO=jasonish/suricata-verify -f SV_BRANCH=pr-staging/1

@catenacyber
Copy link
Contributor

Could you rebase, so that I approve again, to see if firing CODEOWNERS fixed the approved PR filter ?

A workflow dispatch allows us to manually a trigger a workflow with
arguments. This dispatch allows us to use the "gh" cli command to
trigger a workflow run with our libhtp/su/sv branch and repo variables
set. For example:

  gh run builds.yml -f SV_REPO=jasonish/suricata-verify -f SV_BRANCH=pr/10
@jasonish jasonish force-pushed the github-ci/workflow-dispatch/v1 branch from d1c6b66 to d6cf757 Compare May 24, 2023 15:53
@jasonish
Copy link
Member Author

Could you rebase, so that I approve again, to see if firing CODEOWNERS fixed the approved PR filter ?

Done.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase is good

@catenacyber catenacyber mentioned this pull request May 31, 2023
@victorjulien victorjulien mentioned this pull request Jun 2, 2023
@victorjulien
Copy link
Member

Merged in #8951, thanks!

@jasonish jasonish deleted the github-ci/workflow-dispatch/v1 branch June 5, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants