debug: fix list-x command line options with debug#8921
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
debug: fix list-x command line options with debug#8921catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Debug validation checks that engine is either IPS or IDS. But listing keywords does not care. So, adding a new mode for this case. Ticket: OISF#6089
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8921 +/- ##
==========================================
+ Coverage 82.30% 82.34% +0.04%
==========================================
Files 969 969
Lines 273335 273339 +4
==========================================
+ Hits 224961 225085 +124
+ Misses 48374 48254 -120
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 14039 |
lukashino
requested changes
May 31, 2023
Contributor
lukashino
left a comment
There was a problem hiding this comment.
I think it would be better to go with EngineModeSetIDS approach so that we don't need to create a separate engine runmode. It is done so in other cases where Suricata doesn't particularly operate in IDS mode (only tests some part of Suricata).
Otherwise LGTM
Contributor
Author
|
Replaced by #8956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6089
Steps to reproduce :
./src/tests/fuzz/oss-fuzz-configure.sh./src/suricata --list-keywordsor./src/suricata --list-app-layer-protosThis fails with stack trace
This hinders oss-fuzz which relies on these commands
Describe changes:
Another fix could just be to
EngineModeSetIDSinListKeywordsModifies #8909 with ticket in message commit