debug: fix list-x command line options with debug#8956
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
debug: fix list-x command line options with debug#8956catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Debug validation checks that engine is either IPS or IDS. But listing keywords does not care. So, setting ids mode Ticket: OISF#6089
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8956 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 969 969
Lines 273558 273560 +2
=======================================
+ Hits 225404 225413 +9
+ Misses 48154 48147 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 14217 |
victorjulien
approved these changes
Jun 5, 2023
Merged
Member
|
Merged in #8965, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6089
Steps to reproduce :
./src/tests/fuzz/oss-fuzz-configure.sh./src/suricata --list-keywordsor./src/suricata --list-app-layer-protosThis fails with stack trace
This hinders oss-fuzz which relies on these commands
Describe changes:
Another fix could just be to
EngineModeSetIDSinListKeywordsModifies #8921 with fix suggested by @lukashino