smb: fix SMB_COM_WRITE_ANDX record parser - v5#8938
Closed
b1tg wants to merge 2 commits intoOISF:masterfrom
Closed
smb: fix SMB_COM_WRITE_ANDX record parser - v5#8938b1tg wants to merge 2 commits intoOISF:masterfrom
b1tg wants to merge 2 commits intoOISF:masterfrom
Conversation
3 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8938 +/- ##
==========================================
+ Coverage 82.34% 82.38% +0.03%
==========================================
Files 969 969
Lines 273336 273350 +14
==========================================
+ Hits 225090 225201 +111
+ Misses 48246 48149 -97
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Contributor
|
@ct0br0 Can we run QA on this PR ? |
|
What changed? I got the pcaps the other day and I think I saw you say they checked out. Can run but expect a false failure. |
Contributor
Nothing, but there is no QA report in this GitHub PR (there was one on the newt branch) |
|
No, there won't be. Since it is not a team member it will not go into the automated pipeline and qa-bot won't comment on this PR |
Contributor
|
Ok I did not know this :-) |
Merged
Member
|
Merged in #8965, thanks a lot for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #6008
ticket:
https://redmine.openinfosecfoundation.org/issues/6008
Previous PR: #8905
Changes from last PR:
SV_BRANCH=pr/1211