Merged
Conversation
Setting rss_conf->rss_key to NULL and rss_key_len to zero avoids warnings about register changes when setting up RSS configuration through RTE flows.
In DPDK 19.11 Suricata does not setup RSS on i40e driver with rte_flow. As a result, it should not be deinitializing RSS configuration with rte_flow as well.
Header checking (AC_CHECK_HEADER) did not work as DPDK 19.11 included rte_eth_bond.h file even if net/bonding driver was disabled. However, it was still not available in ldconfig configuration. For this reason Bond PMD is checked with ldconfig tool. However when installing the DPDK library manually, the user needs to update the entries in ldconfig to be able to find the Bond PMD. Ticket: OISF#6099
Debug validation checks that engine is either IPS or IDS. But listing keywords does not care. So, setting ids mode Ticket: OISF#6089
When adding an element to the dynamic headers table, the oldest ones may get evicted. When multiple elements get evicted, they should get evicted all at once with drain, instead of one by one as there will be a massive move each time. Ticket: OISF#6103
Issue: 2816 This commit extends the JSON schema with the additional VLAN stat for tracking VLAN encapsulated packets with 3 levels.
Issue: 2816 This commit increase the number of VLAN layers supported by Suricata from 2 to 3. 3-layers are dubbed "Q-in-Q-in-Q". Note that 3 layers are not compliant with any existing standard but are often seen in larger deployments.
This commit removes unused functions and macros related to fetching VLAN values.
Meaning that we support 65535 live devices at the most
For easier reasoning about the code
So that in a setup with different interfaces capturing different networks, flows do not get mixed up Ticket: OISF#5270
Take as much as we can when opening, by making sure that the boundary is not present
victorjulien
requested review from
a team,
catenacyber,
jasonish and
jufajardini
as code owners
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 14242 |
This was referenced Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
Qalab run is expected to fail for 2 reasons: smb hashes will differ and some http hashes will differ.