Skip to content

Comments

doc: GitHub PRs workflow#8955

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:doc-github-prs-v7
Closed

doc: GitHub PRs workflow#8955
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:doc-github-prs-v7

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
None

Describe changes:

  • adds a documentation about GitHub PRs workflow

Draft : to be discussed, and to see if the approved filter with gh command is good enough ?

Modifies #8946 by taking review into account

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8955 (ff6605b) into master (5b160d2) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8955   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         969      969           
  Lines      273558   273558           
=======================================
+ Hits       225404   225409    +5     
+ Misses      48154    48149    -5     
Flag Coverage Δ
fuzzcorpus 64.87% <ø> (+0.01%) ⬆️
suricata-verify 60.48% <ø> (+<0.01%) ⬆️
unittests 62.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -0,0 +1,49 @@
GitHub PRs workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub PR Workflow or GitHub Pull Request Workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering what was mentioned in the last PR, I would go with 'GitHub Pull Requests Workflow' for the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@catenacyber
Copy link
Contributor Author

Replaced by #8959

@catenacyber catenacyber closed this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants