Closed
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8959 +/- ##
=======================================
Coverage 82.39% 82.40%
=======================================
Files 969 969
Lines 273558 273558
=======================================
+ Hits 225404 225426 +22
+ Misses 48154 48132 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
reviewed
Jun 5, 2023
| It is expected that the author creates a new PR with a new version of the patch | ||
| as described in :ref:`Pull Requests Criteria <pull-requests-criteria>`. | ||
|
|
||
| #TODO filter does not work cf https://github.com/OISF/suricata/pull/8898 |
Member
There was a problem hiding this comment.
We should probably not include filters that we know don't work.
Contributor
Author
There was a problem hiding this comment.
Giving up hope to get it fixed ?
https://stackoverflow.com/questions/75637877/github-filtering-not-showing-approved-reviews/76418051#76418051
jufajardini
requested changes
Jun 5, 2023
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Noticed something that I hadn't spotted last time...
Contributor
Author
|
Replaced by #8980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
Draft : to be discussed, and to see if the approved filter with
ghcommand is good enough ?Modifies #8955 by explication PR into "Pull Request"