Skip to content

output/snmp: log version from tx#8977

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:output-alert-applayer-v6.3
Closed

output/snmp: log version from tx#8977
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:output-alert-applayer-v6.3

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins

Describe changes:

  • output/snmp: log version from tx, and not from state

This is a functional change from #8961

Improves commit message from #8967

and not the one from state

If a SNMP flow starts with a V2 version transaction,
then there is a V3i version transaction,
we will now log V3 for the second transaction
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 14284

@victorjulien
Copy link
Member

Merged in #8994, thanks!

@catenacyber
Copy link
Contributor Author

Should I not have created a ticket for this ?

@victorjulien
Copy link
Member

Should I not have created a ticket for this ?

Yes please

@catenacyber
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants