Closed
Conversation
Especially fix setup-app-layer script to not forget this part
and used by bittorrent
And fix setup app layer script up for it
This was referenced Jun 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8961 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 969 957 -12
Lines 273476 272917 -559
==========================================
- Hits 225410 224934 -476
+ Misses 48066 47983 -83
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information:
Pipeline 14239 |
This was referenced Jun 5, 2023
Contributor
Author
|
Waiting for #8977 merge before rebasing |
Contributor
Author
|
Keeping it open because there is more here than in #9005 |
This was referenced Jun 16, 2023
|
Information:
Pipeline 14239 |
Contributor
Author
|
Closing for now |
This was referenced Sep 18, 2023
This was referenced Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Continuation of #8772
https://redmine.openinfosecfoundation.org/issues/5977
Describe changes:
Continues #8922 with review taken into account
OISF/suricata-verify#1196
Still to do :
Any ideas about the commit segmentation ? and PR splitting ?
I guess I should make a first smaller version with uncontroversial changes