output/alert: rewrite code for app-layer properties#9511
output/alert: rewrite code for app-layer properties#9511catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Especially fix setup-app-layer script to not forget this part Ticket: OISF#3827
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9511 +/- ##
==========================================
- Coverage 82.19% 82.16% -0.03%
==========================================
Files 968 968
Lines 274203 274059 -144
==========================================
- Hits 225373 225193 -180
- Misses 48830 48866 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16262 |
jasonish
left a comment
There was a problem hiding this comment.
I want to see this land as soon as possible, but I also want the commit message to explain a little bit more about whats going on. The ticket referenced may be related, but this is more about the actual logging, then the initialization of logging.
|
Still not really a fan of introducing a new global hard coded table. But I guess if this is a step towards making things more dynamic I can live with it. |
Yeah, me to. I think without this step, future steps will just take longer to complete tho. |
|
Replaced by #9768 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3827
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
preliminary work for https://redmine.openinfosecfoundation.org/issues/5977 as well
Part of #8961
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C files#9252 with some renaming as per code review + reusing code for output-json-file.c
Same as #9499 but without the force-push on github