output/alert: rewrite code for app-layer properties#9768
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
output/alert: rewrite code for app-layer properties#9768catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Especially fix setup-app-layer script to not forget this part This allows, for simple loggers, to have a unique definition of the actual logging function with the jsonbuilder. This way, alerts, files, and app-layer event can share the code to output the same data. Ticket: OISF#3827
catenacyber
requested review from
a team,
jasonish and
victorjulien
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9768 +/- ##
==========================================
- Coverage 82.39% 82.31% -0.09%
==========================================
Files 968 968
Lines 273871 273727 -144
==========================================
- Hits 225653 225315 -338
- Misses 48218 48412 +194
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16441 |
Member
Is there a ticket for this? I'm also working on a fix for DNS metadata in alerts: https://redmine.openinfosecfoundation.org/issues/6281 |
Contributor
Author
https://redmine.openinfosecfoundation.org/issues/5977 for krb5 and there are other for other protocols |
This was referenced Nov 16, 2023
Contributor
Author
|
Continued in #9839 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3827
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
preliminary work for https://redmine.openinfosecfoundation.org/issues/5977 as well
Part of #8961
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C files#9511 with rebase and enhanced commit message