Merged
Conversation
Especially fix setup-app-layer script to not forget this part This allows, for simple loggers, to have a unique definition of the actual logging function with the jsonbuilder. This way, alerts, files, and app-layer event can share the code to output the same data. Ticket: OISF#3827
Ticket: 6500
Ticket: 6501
Ticket: 5977
catenacyber
requested review from
a team,
jasonish and
victorjulien
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9851 +/- ##
==========================================
- Coverage 82.47% 82.45% -0.02%
==========================================
Files 973 973
Lines 273962 273813 -149
==========================================
- Hits 225944 225771 -173
- Misses 48018 48042 +24
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 16663 |
victorjulien
approved these changes
Nov 21, 2023
Merged
Member
|
Merged in #9853, thanks! |
This was referenced Nov 21, 2023
This was referenced Apr 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
https://redmine.openinfosecfoundation.org/issues/5977
https://redmine.openinfosecfoundation.org/issues/6500
https://redmine.openinfosecfoundation.org/issues/6501
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Describe changes:
After that, there is still to take from #9812
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C files#9839 rwith some renaming
OISF/suricata-verify#1482