-
Notifications
You must be signed in to change notification settings - Fork 153
core: Add FilteredTransactionsManager config and address #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
core: Add FilteredTransactionsManager config and address #604
Conversation
Tristan-Wilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| var ArbosAddress = common.HexToAddress("0xa4b05") | ||
| var ArbosStateAddress = common.HexToAddress("0xA4B05FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF") | ||
| var FilteredTransactionsStateAddress = common.HexToAddress("0xA4B0600000000000000000000000000000000000") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now is our chance to come up with some 1337sp34k like CE175012ED, or we can just go with ArbosStateAddress+1 like what we have already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
0xA4B0500000000000000000000000000000000001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have the constant name start with arbos so it'll be easy to understand it's for arbitrum
87b33d7 to
0613914
Compare
Part of NIT-4245
pulled in by OffchainLabs/nitro#4174
Changes:
FilteredTransactionsStateAddressandArbFilteredTransactionsManagerAddresstotypes/arbitrum_signer.goTransactionFilteringEnabledtoparams/config/ArbOSInit