Add ArbFilteredTransactionsManager precompile #4174
+812
−126
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Copyright 2025, Offchain Labs, Inc. | ||
| // For license information, see https://github.com/OffchainLabs/nitro/blob/master/LICENSE.md | ||
|
|
||
| package filteredTransactions | ||
|
|
||
| import ( | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/core/vm" | ||
|
|
||
| "github.com/offchainlabs/nitro/arbos/burn" | ||
| "github.com/offchainlabs/nitro/arbos/storage" | ||
| ) | ||
|
|
||
| var presentHash = common.BytesToHash([]byte{1}) | ||
|
|
||
| type FilteredTransactionsState struct { | ||
| store *storage.Storage | ||
| } | ||
|
|
||
| func Open(statedb vm.StateDB, burner burn.Burner) *FilteredTransactionsState { | ||
| return &FilteredTransactionsState{ | ||
| store: storage.FilteredTransactionsStorage(statedb, burner), | ||
| } | ||
| } | ||
|
|
||
| func (s *FilteredTransactionsState) Add(txHash common.Hash) error { | ||
| return s.store.Set(txHash, presentHash) | ||
| } | ||
|
|
||
| func (s *FilteredTransactionsState) Delete(txHash common.Hash) error { | ||
| return s.store.Clear(txHash) | ||
| } | ||
|
|
||
| func (s *FilteredTransactionsState) IsFiltered(txHash common.Hash) (bool, error) { | ||
| value, err := s.store.Get(txHash) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return value == presentHash, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| ### Added | ||
| - Add new precompile ArbFilteredTransactionsManager to manage filtered transactions | ||
| - Add transaction filterers to ArbOwner to limit access to ArbFilteredTransactionsManager | ||
| - Limit ArbOwners ability to create transaction filterers with TransactionFilteringFromTime | ||
|
||
Submodule precompiles
updated
3 files
| +37 −0 | ArbFilteredTransactionsManager.sol | |
| +40 −0 | ArbOwner.sol | |
| +19 −0 | ArbOwnerPublic.sol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright 2025, Offchain Labs, Inc. | ||
| // For license information, see https://github.com/OffchainLabs/nitro/blob/master/LICENSE.md | ||
|
|
||
| package precompiles | ||
|
|
||
| import ( | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/core/vm" | ||
|
|
||
| "github.com/offchainlabs/nitro/arbos/filteredTransactions" | ||
| ) | ||
|
|
||
| // ArbFilteredTransactionsManager precompile enables ability to filter transactions by authorized callers. | ||
| // Authorized callers are added/removed through ArbOwner precompile. | ||
| type ArbFilteredTransactionsManager struct { | ||
| Address addr // 0x74 | ||
|
|
||
| FilteredTransactionAdded func(ctx, mech, common.Hash) error | ||
| FilteredTransactionAddedGasCost func(common.Hash) (uint64, error) | ||
gligneul marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| FilteredTransactionDeleted func(ctx, mech, common.Hash) error | ||
| FilteredTransactionDeletedGasCost func(common.Hash) (uint64, error) | ||
| } | ||
|
|
||
| // Adds a transaction hash to the filtered transactions list | ||
| func (con ArbFilteredTransactionsManager) AddFilteredTransaction(c *Context, evm *vm.EVM, txHash common.Hash) error { | ||
| if !con.hasAccess(c) { | ||
| return c.BurnOut() | ||
| } | ||
|
|
||
| filteredState := filteredTransactions.Open(evm.StateDB, c) | ||
| if err := filteredState.Add(txHash); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return con.FilteredTransactionAdded(c, evm, txHash) | ||
| } | ||
|
|
||
| // Deletes a transaction hash from the filtered transactions list | ||
| func (con ArbFilteredTransactionsManager) DeleteFilteredTransaction(c *Context, evm *vm.EVM, txHash common.Hash) error { | ||
| if !con.hasAccess(c) { | ||
| return c.BurnOut() | ||
| } | ||
|
|
||
| filteredState := filteredTransactions.Open(evm.StateDB, c) | ||
| if err := filteredState.Delete(txHash); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return con.FilteredTransactionDeleted(c, evm, txHash) | ||
| } | ||
|
|
||
| // Checks if a transaction hash is in the filtered transactions list | ||
| func (con ArbFilteredTransactionsManager) IsTransactionFiltered(c *Context, evm *vm.EVM, txHash common.Hash) (bool, error) { | ||
| filteredState := filteredTransactions.Open(evm.StateDB, c) | ||
| return filteredState.IsFiltered(txHash) | ||
| } | ||
|
|
||
| func (con ArbFilteredTransactionsManager) hasAccess(c *Context) bool { | ||
| manager, err := c.State.TransactionFilterers().IsMember(c.caller) | ||
| return manager && err == nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both fixed