Skip to content

Conversation

@qfai
Copy link
Contributor

@qfai qfai commented Dec 31, 2025

Summary

This PR fixes build failures in three samples that were causing E2E tests to fail.

Changes

1. intelligent-data-chart-generator/api

  • Problem: TypeScript compilation fails with 59 errors due to `@types/node@25` (transitive dependency from `mssql`) being incompatible with TypeScript 4.9.5
  • Fix:
    • Add `@types/node@^20.17.12` explicitly to pin compatible version
    • Upgrade TypeScript from `^4.9.5` to `^5.6.3`
    • Update tsconfig.json to use `module: NodeNext` and `target: ES2022`

2. hello-world-tab-with-backend/api

  • Problem: TypeScript compilation fails with 99 errors (Cannot find namespace 'NodeJS', Cannot find name 'Buffer', etc.)
  • Fix:
    • Add `@types/node@^20.17.12`
    • Upgrade TypeScript from `^4.4.4` to `^5.6.3`
    • Update tsconfig.json to use `module: NodeNext` and `target: ES2022`

3. todo-list-with-Azure-backend-M365

  • Problem: `devTool/install` action fails with `DotnetInstallationError: Unable to check and install .NET Core SDK` even when .NET is already installed in CI
  • Fix: Remove the `devTool/install` action and use system `dotnet` directly (CI environment already has .NET installed via `actions/setup-dotnet`)

Testing

Verified all three samples build successfully after the changes:

# intelligent-data-chart-generator/api
npm install && npm run build  # ✅ Success

# hello-world-tab-with-backend/api  
npm install && npm run build  # ✅ Success

# hello-world-tab-with-backend (root - React app)
npm install && npm run build  # ✅ Success

Related Issues

These fixes address E2E test failures in:

  • ProvisionIntelligentDataChart.tests.ts
  • ProvisionHelloWorldTabBackEnd.tests.ts
  • ProvisionTodoListM365.tests.ts

- intelligent-data-chart-generator/api: Add @types/node and upgrade TypeScript to 5.6.3
- hello-world-tab-with-backend/api: Add @types/node and upgrade TypeScript to 5.6.3
- todo-list-with-Azure-backend-M365: Remove devTool/install action that fails in CI

Issues:
- TypeScript 4.x is incompatible with @types/node@25 (transitive dep from mssql)
- devTool/install fails with DotnetInstallationError even when .NET is installed
qfai added 2 commits December 31, 2025 13:33
…nd-M365

The devTool/install action is required for downloading Agent Playground
to simulate Teams client for bot debugging.

The actual fix for DotnetInstallationError is in fx-core's dotnetChecker.ts
which needs to support .NET 7.0/8.0/9.0 versions.
…with comments

Both useEffect hooks are intentionally designed to run only once on mount:
- useData: auto-fetch initial data once, user calls reload() manually afterwards
- useTeams: initialize Teams SDK and register event handlers once

Added eslint-disable-next-line with explanatory comments to clarify the intent.
This fixes CI build failure where warnings are treated as errors.
@qfai qfai merged commit ec60463 into dev Jan 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants