issue #763 LCO List Component based on new Figma design #782
Conversation
|
@actuallyyun is attempting to deploy a commit to the openbeta-dev Team on Vercel. A member of the Team first needs to authorize it. |
|
I had a close look at |
Let me have look at the Figma and then I can give you a better feedback. In general we're deprecating the
If you use Radix UI trigger then Yes you can customize the trigger using your own component. Look into the Ps: also when ready please share some screen shots |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Super good to know! Should I try to stay with |
|
Regarding implementation for trigger it depends on whether we decide the LCO profile card to be a hover card (open on hover) or a modal popup (open on click). Add area modal
https://github.com/OpenBeta/open-tacos/blob/develop/src/components/edit/Triggers.tsx#L95 I think for the scope of this PR, you can simply let users click on the LCO website link and we can figure out the LCO card in another PR. LCO icon placeholder: the users hero icon will do for now import { UsersIcon } from '@heroicons/react/24/outline' |
|
Cool I will finish up the UI. How about the info icon tooltip? Should I leave it out for now as well? @vnugent |
|
Can you fix linting errors? I can merge it and you can do a follow up PR for tool tips and other things. |
fixed! |
|
Should I undo the lco test data before you merge it? |
yes please. We want the existing LCO info to continue to work. |
|
Removed tooltip and test data. |
|
@actuallyyun let me know when it's ready to merge. You'll need to resolve some conflicts in cragSummary.tsx |
@vnugent ready to merge! |
|
Did the build and linter pass locally in your env? (you can commit without --no-verify flag) https://github.com/OpenBeta/open-tacos/actions/runs/4820193159/jobs/8584351722?pr=782#step:5:10 |
actuallyyun
changed the title
|
Sorry I must have reversed the linting errors I had fixed earlier when I resolved the merge conflicts. It should be fixed now. |
|
@zichongkao I think recent changes to the LCO history object breaks the frontend build https://github.com/OpenBeta/open-tacos/actions/runs/4829298519/jobs/8604171055?pr=782#step:8:43 |
|
Thanks for pointing this out! I'll take a look and put in a fix by today! |
|
This should fix it: #805 together with OpenBeta/openbeta-graphql#276. But we need the openbeta-graphql changes to be deployed so the open-taco change can be built before we merge it. Then I'll rebase this PR onto these changes! |
|
#805 merged. @zichongkao or @actuallyyun can you please rebase this PR then we're good to merge. Thank you! |
|
@actuallyyun This is actually a branch on your repo, so you'll have to rebase -- I can't do it. Sorry for the trouble! |
|
Rebased and pushed |
* feat:move lco banner from left to right * feat:if no lco found, show empty state * use custom background color * replace info icon svg with react component * add previous hover card implementation in comments * change LCO logo placeholder to UsersIcon * style:use de-emphasized color for empty lco state text * fix linting errors * remove tooltip * click on lco link opens a new tag * add tooltip to show learn more * fix linting errors
Empty State
Happy Path
web
mobile
-Tooltip