Fix getChangeHistory #805
Merged
Fix getChangeHistory #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zichongkao
commented
Apr 29, 2023
zichongkao
force-pushed
the
kao-org-change-histoyr
branch
from
e56c407
to
eda4526
Compare
zichongkao
force-pushed
the
kao-org-change-histoyr
branch
from
eda4526
to
db8b112
Compare
zichongkao
force-pushed
the
kao-org-change-histoyr
branch
from
db8b112
to
472e6f9
Compare
zichongkao
force-pushed
the
kao-org-change-histoyr
branch
from
472e6f9
to
99ec881
Compare
zichongkao
commented
Apr 29, 2023
| @@ -51,7 +52,7 @@ const ChangesetRow = ({ changeset }: ChangsetRowProps): JSX.Element => { | |||
| } | |||
|
|
|||
| const ClimbChange = ({ changeId, fullDocument, updateDescription, dbOp }: ChangeType): JSX.Element | null => { | |||
| if ((fullDocument as ClimbType)?.name == null) { | |||
| if (fullDocument.__typeName !== DocumentTypeName.Climb) { | |||
There was a problem hiding this comment.
More robust to use __typename than unique document fields: https://www.apollographql.com/docs/apollo-server/schema/unions-interfaces/#querying-a-union
|
Note that builds will keep failing until newest openbeta-graphql changes are deployed to staging. Otherwise during build, we prepare static props which requires calling the staging API and that fails because the old code doesn't expect Organization document changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to breakage reported here: #782.
In working on this, I considered whether we should be showing Organizations history in the general changelog. I feel it could go either way:
In the end, I figured we can just expand functionality to show a change (including those for organizations) if it exists. If we want to remove organization changes, the best place is probably at the GraphQL query layer, by adding a filter.
The current filter doesn't support
kind. The problem is that a changelog of a certain kind can involve documents of multiple kinds. Eg. add climb (changelogkind== 'climbs') involves inserting a climb (documentkind== 'climbs') and updating the parent area (documentkind= 'areas'). It's not clear whether we should include the parent area document change when filtering for climbing changelogs. So there's some nuance here to think about.For context,
kindis stabilized on the backend in this OpenBeta/openbeta-graphql#277.