Add more typing for history objects #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zichongkao
force-pushed
the
kao-history-types
branch
2 times, most recently
from
93a5e35
to
9f89a09
Compare
zichongkao
force-pushed
the
kao-history-types
branch
from
9f89a09
to
cb262d7
Compare
zichongkao
commented
Apr 29, 2023
| case DocumentKind.organizations: | ||
| return 'Organization' | ||
| default: | ||
| return exhaustiveCheck(node.kind) |
There was a problem hiding this comment.
Don't know if there's a better way to do this!
zichongkao
commented
Apr 29, 2023
| @@ -49,7 +50,7 @@ const onChange = (change: ChangeStreamDocument): void => { | |||
| case 'replace': | |||
| case 'update': { | |||
| let dbOp: DBOperation = 'update' | |||
| const source = change.ns.coll | |||
| const source = DocumentKind[change.ns.coll] | |||
There was a problem hiding this comment.
Hope this is fine. Dunno if we can type change.ns.coll as well.
|
Thanks for the fix. In general I think we should prioritize climb & area history. As you said in the other comment the LCO edit feature will be used by very a few trusted individual. |
|
@all-contributors add @zichongkao @musoke for code & ideas |
|
I've put up a pull request to add @zichongkao! 🎉 |
l4u532
pushed a commit
to l4u532/openbeta-graphql
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kindto be an enum instead of string.OrganizationTypeas aSupportedCollectionType.