feat: Ice context #283
Merged
feat: Ice context #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@musoke @zichongkao can we revisit this PR? |
|
Yup. I was waiting for things to settle with the LCO org and picture rewrite. |
|
@actuallyyun, could you take a look at the errors here? I'm updating the version of sandbag here and getting errors relating to |
|
|
This was referenced Jun 19, 2023
Merged
musoke
force-pushed
the
ice-context
branch
3 times, most recently
from
e6b80aa
to
1afcc2a
Compare
The grade contexts know nothing about ice climbing grades. Instead, they use sport/trad grades. Add support for ice climbs with WI grades. This commit assumes that all contexts use only Winter Ice grades. This does not completely reflect real world usage - single regions often have a mix of WI and AI grades. In the short term, this could be overriden for local areas. Longer term, ice grades allowed in these contexts should be either of `GradeScales.AI` and `GradeScales.WI`.
vnugent
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for ice climbs with the WI grade scales.
This currently assumes that all contexts use only Winter Ice grades rather than a mix of Alpine Ice and Winter Ice. This is not the case; the grade scale depends on the local climate.
To enable AI grades in future, the ice grades allowed in most contexts should be an array:
[GradeScales.AI, GradeScales.WI].Depends on