Skip to content

Fixes inconsistencies with text handling, adds splittext_char() #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Fixes inconsistencies with text handling, adds splittext_char() #2351

wants to merge 10 commits into from

Conversation

@Kapu1178
Copy link
Contributor

@Kapu1178 Kapu1178 commented Jul 22, 2025 •
edited
Loading

fixes:

  • copytext_char() using text elements instead of runes.
  • splicetext_char() using text elements instead of runes.
  • text2ascii_char() using text elements instead of runes.
  • spantext_char() using text elements instead of runes.

adds: splittext_char()

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Jul 22, 2025
@Kapu1178 Kapu1178 marked this pull request as draft July 22, 2025 07:01
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2025
View reviewed changes
OpenDreamRuntime/Procs/Native/DreamProcNativeRoot.cs
return SplitText(bundle, src, usr, false);
}

private static DreamValue SplitText(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr, bool useByteLength) {

Check warning

Code scanning / InspectCode

Unused parameter: Private accessibility Warning

Parameter 'src' is never used
OpenDreamRuntime/Procs/Native/DreamProcNativeRoot.cs
return SplitText(bundle, src, usr, false);
}

private static DreamValue SplitText(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr, bool useByteLength) {

Check warning

Code scanning / InspectCode

Unused parameter: Private accessibility Warning

Parameter 'usr' is never used
@Kapu1178 Kapu1178 changed the title Fixes parity break with text lengths and what is considered a "character" Fixes inconsistencies with text handling, adds splittext_char() Jul 23, 2025
@github-actions github-actions bot added size/L and removed size/M labels Jul 23, 2025
@github-actions
Copy link

github-actions bot commented Aug 10, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Merge Conflict Runtime Involves the OpenDream server/runtime size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kapu1178