Skip to content

Fixes inconsistencies with text handling, adds splittext_char() #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Fixes inconsistencies with text handling, adds splittext_char() #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e9b3c85
fix length()
Kapu1178 Jul 22, 2025
ade1cf5
fix splittext, add splittext_char, fix length()
Kapu1178 Jul 22, 2025
f452390
copytext and copytext_char
Kapu1178 Jul 22, 2025
8b6172d
text helpers
Kapu1178 Jul 22, 2025
e4d676d
revert back to chars
Kapu1178 Jul 23, 2025
003cf0c
revert copytext
Kapu1178 Jul 23, 2025
3ac588e
splicetext_char -> runes
Kapu1178 Jul 23, 2025
9815d4b
text2ascii_char
Kapu1178 Jul 23, 2025
b57ee39
spantext_char
Kapu1178 Jul 23, 2025
79a0910
fix
Kapu1178 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions OpenDreamRuntime/Procs/Native/DreamProcNative.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ public static void SetupNativeProcs(DreamObjectTree objectTree) {
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_splicetext);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_splicetext_char);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_splittext);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_splittext_char);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_stat);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_statpanel);
objectTree.SetGlobalNativeProc(DreamProcNativeRoot.NativeProc_text2ascii);
Expand Down
102 changes: 61 additions & 41 deletions OpenDreamRuntime/Procs/Native/DreamProcNativeRoot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
using Robust.Server;
using Robust.Shared.Asynchronous;
using Vector4 = Robust.Shared.Maths.Vector4;
using OpenDreamRuntime.Util;

namespace OpenDreamRuntime.Procs.Native;

Expand Down Expand Up @@ -651,18 +652,20 @@ public static DreamValue NativeProc_copytext_char(NativeProc.Bundle bundle, Drea
if (!bundle.GetArgument(1, "Start").TryGetValueAsInteger(out int start)) //1-indexed
return new DreamValue("");

StringInfo textElements = new StringInfo(text);
;

if (end <= 0) end += textElements.LengthInTextElements + 1;
else if (end > textElements.LengthInTextElements + 1) end = textElements.LengthInTextElements + 1;
Rune[] runes = text.EnumerateRunes().ToArray();

if (end <= 0) end += runes.Length + 1;
else if (end > runes.Length + 1) end = runes.Length + 1;

if (start == 0) return new DreamValue("");
else if (start < 0) start += textElements.LengthInTextElements + 1;
else if (start < 0) start += runes.Length + 1;

if (start > textElements.LengthInTextElements)
return new(string.Empty);
if (start > runes.Length)
return new DreamValue(string.Empty);

return new DreamValue(textElements.SubstringByTextElements(start - 1, end - start));
return new DreamValue(TextHelpers.RuneSubstring(runes, start - 1, end - 1));
}

[DreamProc("CRASH")]
Expand Down Expand Up @@ -2653,24 +2656,24 @@ public static DreamValue NativeProc_spantext_char(NativeProc.Bundle bundle, Drea
return new DreamValue(0);
}

StringInfo textStringInfo = new StringInfo(text);
Rune[] runes = text.EnumerateRunes().ToArray();

if(start < 0) {
start = Math.Max(start + textStringInfo.LengthInTextElements + 1, 1);
start = Math.Max(start + runes.Length + 1, 1);
}

int result = 0;

TextElementEnumerator needlesElementEnumerator = StringInfo.GetTextElementEnumerator(needles);
TextElementEnumerator textElementEnumerator = StringInfo.GetTextElementEnumerator(text, start - 1);
IEnumerator<Rune> needlesRuneEnumerator = needles.EnumerateRunes();
IEnumerator<Rune> textRuneEnumerator = TextHelpers.RuneSubstring(runes, start - 1, 0).EnumerateRunes();

while(textElementEnumerator.MoveNext()) {
while(textRuneEnumerator.MoveNext()) {
bool found = false;
needlesElementEnumerator.Reset();
needlesRuneEnumerator.Reset();

//lol O(N*M)
while (needlesElementEnumerator.MoveNext()) {
if (textElementEnumerator.Current.Equals(needlesElementEnumerator.Current)) {
while (needlesRuneEnumerator.MoveNext()) {
if (textRuneEnumerator.Current.Equals(needlesRuneEnumerator.Current)) {
result++;
found = true;
break;
Expand Down Expand Up @@ -2752,22 +2755,23 @@ public static DreamValue NativeProc_splicetext_char(NativeProc.Bundle bundle, Dr
else if(text == "")
return new DreamValue(insertText);

Rune[] runes = text.EnumerateRunes().ToArray();

//runtime if start = 0 runtime error: bad text or out of bounds
StringInfo textElements = new StringInfo(text);
if(end == 0 || end > textElements.LengthInTextElements + 1)
end = textElements.LengthInTextElements+1;
if (end == 0 || end > runes.Length + 1)
end = runes.Length + 1;
if(start < 0)
start = Math.Max(start + textElements.LengthInTextElements + 1, 1);
start = Math.Max(start + runes.Length + 1, 1);
if(end < 0)
end = Math.Min(end + textElements.LengthInTextElements + 1, textElements.LengthInTextElements);
end = Math.Min(end + runes.Length + 1, runes.Length);

if(start == 0 || start > textElements.LengthInTextElements || start > end)
throw new Exception("bad text or out of bounds");
if(start == 0 || start > runes.Length || start > end)
throw new ArgumentException("bad text or out of bounds");

string result = textElements.SubstringByTextElements(0, start - 1);
string result = TextHelpers.RuneSubstring(runes, 0, start - 1);
result += insertText;
if(end <= textElements.LengthInTextElements)
result += textElements.SubstringByTextElements(end - 1);
if(end <= runes.Length)
result += TextHelpers.RuneSubstring(runes, end - 1, 0);

return new DreamValue(result);
}
Expand All @@ -2779,30 +2783,46 @@ public static DreamValue NativeProc_splicetext_char(NativeProc.Bundle bundle, Dr
[DreamProcParameter("End", Type = DreamValueTypeFlag.Float, DefaultValue = 0)]
[DreamProcParameter("include_delimiters", Type = DreamValueTypeFlag.Float, DefaultValue = 0)]
public static DreamValue NativeProc_splittext(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr) {
return SplitText(bundle, src, usr, true);
}

[DreamProc("splittext_char")]
[DreamProcParameter("Text", Type = DreamValueTypeFlag.String)]
[DreamProcParameter("Delimiter", Type = DreamValueTypeFlag.String)]
[DreamProcParameter("Start", Type = DreamValueTypeFlag.Float, DefaultValue = 1)]
[DreamProcParameter("End", Type = DreamValueTypeFlag.Float, DefaultValue = 0)]
[DreamProcParameter("include_delimiters", Type = DreamValueTypeFlag.Float, DefaultValue = 0)]
public static DreamValue NativeProc_splittext_char(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr) {
return SplitText(bundle, src, usr, false);
}

private static DreamValue SplitText(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr, bool useByteLength) {

Check warning

Code scanning / InspectCode

Unused parameter: Private accessibility Warning

Parameter 'src' is never used

Check warning

Code scanning / InspectCode

Unused parameter: Private accessibility Warning

Parameter 'usr' is never used
if (!bundle.GetArgument(0, "Text").TryGetValueAsString(out var text)) {
return new DreamValue(bundle.ObjectTree.CreateList());
}

int consideredLength = useByteLength ? text.Length : text.EnumerateRunes().Count();
int start = 0;
int end = 0;
if(bundle.GetArgument(2, "Start").TryGetValueAsInteger(out start))
if (bundle.GetArgument(2, "Start").TryGetValueAsInteger(out start))
start -= 1; //1-indexed
if(bundle.GetArgument(3, "End").TryGetValueAsInteger(out end))
if(end == 0)
end = text.Length;
if (bundle.GetArgument(3, "End").TryGetValueAsInteger(out end))
if (end == 0)
end = consideredLength;
else
end -= 1; //1-indexed

bool includeDelimiters = false;
if(bundle.GetArgument(4, "include_delimiters").TryGetValueAsInteger(out var includeDelimitersInt))
if (bundle.GetArgument(4, "include_delimiters").TryGetValueAsInteger(out var includeDelimitersInt))
includeDelimiters = includeDelimitersInt != 0; //idk why BYOND doesn't just use truthiness, but it doesn't, so...

if(start > 0 || end < text.Length)
text = text[Math.Max(start,0)..Math.Min(end, text.Length)];
if (start > 0 || end < consideredLength)
text = text[Math.Max(start, 0)..Math.Min(end, consideredLength)];

var delim = bundle.GetArgument(1, "Delimiter"); //can either be a regex or string

if (delim.TryGetValueAsDreamObject<DreamObjectRegex>(out var regexObject)) {
if(includeDelimiters) {
if (includeDelimiters) {
var values = new List<string>();
int pos = 0;
foreach (Match m in regexObject.Regex.Matches(text)) {
Expand All @@ -2818,13 +2838,13 @@ public static DreamValue NativeProc_splittext(NativeProc.Bundle bundle, DreamObj
}
} else if (delim.TryGetValueAsString(out var delimiter)) {
string[] splitText;
if(includeDelimiters) {
if (includeDelimiters) {
//basically split on delimeter, and then add the delimiter back in after each split (except the last one)
splitText= text.Split(delimiter);
splitText = text.Split(delimiter);
string[] longerSplitText = new string[splitText.Length * 2 - 1];
for(int i = 0; i < splitText.Length; i++) {
for (int i = 0; i < splitText.Length; i++) {
longerSplitText[i * 2] = splitText[i];
if(i < splitText.Length - 1)
if (i < splitText.Length - 1)
longerSplitText[i * 2 + 1] = delimiter;
}

Expand Down Expand Up @@ -2914,17 +2934,17 @@ public static DreamValue NativeProc_text2ascii_char(NativeProc.Bundle bundle, Dr
return new DreamValue(0);
}

StringInfo textElements = new StringInfo(text);
Rune[] runes = text.EnumerateRunes().ToArray();

bundle.GetArgument(1, "pos").TryGetValueAsInteger(out var pos); //1-indexed
if (pos == 0) pos = 1; //0 is same as 1
else if (pos < 0) pos += textElements.LengthInTextElements + 1; //Wraps around
else if (pos < 0) pos += runes.Length + 1; //Wraps around

if (pos > textElements.LengthInTextElements || pos < 1) {
if (pos > runes.Length || pos < 1) {
return new DreamValue(0);
} else {
//practically identical to (our) text2ascii but more explicit about subchar indexing
return new DreamValue((int)textElements.SubstringByTextElements(pos - 1, 1)[0]);
return new DreamValue((int)runes[pos].ToString()[0]);
}
}

Expand Down
21 changes: 21 additions & 0 deletions OpenDreamRuntime/Util/TextHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
using System.Text;

namespace OpenDreamRuntime.Util;

public static class TextHelpers {
// Returns a slice of a rune array as a string.
public static string RuneSubstring(Rune[] runes, int start, int end) {
if (start < 0) throw new ArgumentOutOfRangeException("Start position is less than zero");
if (end < 0 || end > runes.Length) throw new ArgumentOutOfRangeException("End position is not within array size");

if (end == 0) {
end = runes.Length;
}

var stringBuilder = new StringBuilder();
for (int i = start; i < end; i++) {
stringBuilder.Append(runes[i].ToString());
}
return stringBuilder.ToString();
}
}
Loading