Skip to content

fix: remove   from column header text for aria-label accessibility#19

Merged
jguo144 merged 1 commit intomasterfrom
jguo144/2026-03-12/fix-aria-label
Mar 13, 2026
Merged

fix: remove   from column header text for aria-label accessibility#19
jguo144 merged 1 commit intomasterfrom
jguo144/2026-03-12/fix-aria-label

Conversation

@jguo144
Copy link
Collaborator

@jguo144 jguo144 commented Mar 12, 2026

Description

Column headers in DataTable views were replacing spaces in column names with the string  . DataTables derives the aria-label for sort buttons from the content by stripping HTML tags but does not decode HTML entities.

As a result, the generated aria-label values contained literal   strings (for example: Column Name  : activate to sort column ascending). Screen readers would read these literally as “ampersand n b s p semicolon” instead of interpreting them as spaces.

Changes

  • Removed nbspval variable
  • Changed to {{ field.info.label + " " }} and {{ field.id + " " }} (adds regular space)
  • Moved   to only appear after the info icon (when present)

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@jguo144
Copy link
Collaborator Author

jguo144 commented Mar 12, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@jguo144 jguo144 requested a review from nolanpruett March 12, 2026 20:57
@jguo144 jguo144 enabled auto-merge (squash) March 12, 2026 21:03
@jguo144 jguo144 merged commit c18f507 into master Mar 13, 2026
9 checks passed
@jguo144 jguo144 deleted the jguo144/2026-03-12/fix-aria-label branch March 13, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants