Skip to content

fix: remove   from column header text for aria-label accessibility #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jguo144 merged 1 commit into from
Mar 13, 2026
Merged

fix: remove   from column header text for aria-label accessibility #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .../og_datatables_datefilterview/templates/og_datatables_datefilterview/datatables_view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

{#- pass the datadictionary to javascript, so we can init columns there -#}
{%- set datadictionary = h.og_datastore_dictionary(resource.id, resource_view.get('show_fields')) -%}
{%- set nbspval = " "|safe -%}

<script type=text/javascript>
const gdataDict = {{ datadictionary|tojson }}
Expand Down Expand Up @@ -53,15 +52,15 @@
{% if 'show_fields' not in resource_view or field.id in resource_view.show_fields -%}
<th scope="col">
{%- if data_dictionary_labels and field.info is defined and field.info.label|length -%}
{{ field.info.label|replace(" ", nbspval) }}
{{ field.info.label + " " }}
{%- else -%}
{{ field.id|replace(" ", nbspval) }}
{{ field.id + " " }}
{%- endif -%}
&nbsp;
{%- if data_dictionary_labels and field.info is defined and (field.info.label|length or field.info.notes|length)-%}
<i class="fa fa-info-circle" title="{{field.id}} ({{field.type}})&#10;{{ h.markdown_extract(field.info.notes, 300) }}"></i>
&nbsp;
{%- endif -%}
&nbsp;</th>
</th>
{%- endif %}
{% endfor -%}
<th id="_colspacer">colspacer</th>
Expand Down
9 changes: 4 additions & 5 deletions ckanext/og_datatablesview/templates/og_datatables/datatables_view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

{#- pass the datadictionary to javascript, so we can init columns there -#}
{%- set datadictionary = h.og_datastore_dictionary(resource.id, resource_view.get('show_fields')) -%}
{%- set nbspval = "&nbsp;"|safe -%}

<script type=text/javascript>
const gdataDict = {{ datadictionary|tojson }}
Expand Down Expand Up @@ -53,15 +52,15 @@
{% if 'show_fields' not in resource_view or field.id in resource_view.show_fields -%}
<th scope="col">
{%- if data_dictionary_labels and field.info is defined and field.info.label|length -%}
{{ field.info.label|replace(" ", nbspval) }}
{{ field.info.label + " " }}
{%- else -%}
{{ field.id|replace(" ", nbspval) }}
{{ field.id + " " }}
{%- endif -%}
&nbsp;
{%- if data_dictionary_labels and field.info is defined and (field.info.label|length or field.info.notes|length)-%}
<i class="fa fa-info-circle" title="{{field.id}} ({{field.type}})&#10;{{ h.markdown_extract(field.info.notes, 300) }}"></i>
&nbsp;
{%- endif -%}
&nbsp;</th>
</th>
{%- endif %}
{% endfor -%}
<th id="_colspacer">colspacer</th>
Expand Down
Loading