Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace php date functions, Varien_Date with Carbon date library #4463

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
phpstan ignore incomplete tests
  • Loading branch information
sreichel committed Jan 9, 2025
commit 06bb731ce8cd07ca7fe9afeff62764b38cfedac8
Original file line number Diff line number Diff line change
@@ -141,6 +141,7 @@ public function testInitReport($modelClass = ''): void
public function testGetReportFull(): void
{
$this->markTestIncomplete();
// @phpstan-ignore-next-line
$this->assertInstanceOf(Mage_Reports_Model_Report::class, $this->subject->getReportFull(1, 1));
}

@@ -151,6 +152,7 @@ public function testGetReportFull(): void
public function testGetReport(): void
{
$this->markTestIncomplete();
// @phpstan-ignore-next-line
$this->assertInstanceOf(Mage_Reports_Model_Report::class, $this->subject->getReport(1, 1));
}

@@ -161,6 +163,7 @@ public function testGetReport(): void
public function testTimeShift(): void
{
$this->markTestIncomplete();
// @phpstan-ignore-next-line
$this->assertSame($this->subject->timeShift(''));
}
}
2 changes: 1 addition & 1 deletion tests/unit/Varien/ObjectTest.php
Original file line number Diff line number Diff line change
@@ -226,7 +226,7 @@ public function testGetSetUnsData(): void
$this->assertTrue($this->subject->isEmpty());

try {
/** @phpstan-ignore-next-line */
// @phpstan-ignore-next-line
$this->subject->notData();
$this->fail('Invalid __call');
} catch (Varien_Exception $exception) {
Loading