Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace php date functions, Varien_Date with Carbon date library #4463

Closed
wants to merge 13 commits into from
Closed
Prev Previous commit
Next Next commit
composer update
sreichel committed Jan 6, 2025
commit 69e65f41f479d31386b2c96e3ef975ffced18ac5
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@
"phpmd/phpmd": "^2.13",
"phpstan/phpstan": "^2.1",
"phpunit/phpunit": "^9.6",
"rector/rector": "^2.0.5",
"rector/rector": "^2.0",
"squizlabs/php_codesniffer": "^3.7",
"symplify/vendor-patches": "^11.1"
},
30 changes: 15 additions & 15 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


Unchanged files with check annotations Beta

public function testGetReportFull(): void
{
$this->markTestIncomplete();
$this->assertInstanceOf(Mage_Reports_Model_Report::class, $this->subject->getReportFull(1, 1));

Check failure on line 144 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 8.4)

Unreachable statement - code above always terminates.

Check failure on line 144 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 7.4)

Unreachable statement - code above always terminates.
}
/**
public function testGetReport(): void
{
$this->markTestIncomplete();
$this->assertInstanceOf(Mage_Reports_Model_Report::class, $this->subject->getReport(1, 1));

Check failure on line 154 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 8.4)

Unreachable statement - code above always terminates.

Check failure on line 154 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 7.4)

Unreachable statement - code above always terminates.
}
/**
public function testTimeShift(): void
{
$this->markTestIncomplete();
$this->assertSame($this->subject->timeShift(''));

Check failure on line 164 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 8.4)

Unreachable statement - code above always terminates.

Check failure on line 164 in tests/unit/Mage/Reports/Model/Resource/Report/CollectionTest.php

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 7.4)

Unreachable statement - code above always terminates.
}
}