Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: change margin logic #7980

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jul 8, 2024

close #7950

@theocrsb theocrsb requested a review from a team as a code owner July 8, 2024 14:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (c390cb4) to head (814bc2d).

Files Patch % Lines
...onents/ManageTrainSchedule/helpers/formatMargin.ts 0.00% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7980      +/-   ##
============================================
- Coverage     28.25%   28.24%   -0.02%     
  Complexity     2075     2075              
============================================
  Files          1276     1276              
  Lines        156197   156207      +10     
  Branches       3084     3084              
============================================
- Hits          44140    44127      -13     
- Misses       110216   110239      +23     
  Partials       1841     1841              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.98% <ø> (-0.05%) ⬇️
front 9.92% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/update-margin-logic branch from 1c8ece3 to ccbd2d2 Compare July 9, 2024 06:19
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nice !! Thank you

@theocrsb theocrsb force-pushed the tce/front/trainschedule/update-margin-logic branch from ccbd2d2 to 814bc2d Compare July 9, 2024 17:29
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved ✅

@theocrsb theocrsb added this pull request to the merge queue Jul 10, 2024
Merged via the queue into dev with commit 1e07d20 Jul 10, 2024
17 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/update-margin-logic branch July 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSV2 : incorrect standard margin distribution in case of specified passing point
6 participants