Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add route e2e test for operational studies #8042

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Jul 12, 2024

Closes #7912

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (ea0f6c9) to head (b1862de).
Report is 12 commits behind head on dev.

Files Patch % Lines
...s/pathfinding/components/Itinerary/ItineraryV2.tsx 0.00% 11 Missing ⚠️
...omponents/Itinerary/DisplayItinerary/v2/ViasV2.tsx 0.00% 7 Missing ⚠️
...inding/components/Itinerary/ModalSuggestedVias.tsx 0.00% 6 Missing ⚠️
...ts/Itinerary/DisplayItinerary/v2/DestinationV2.tsx 0.00% 3 Missing ⚠️
...ponents/Itinerary/DisplayItinerary/v2/OriginV2.tsx 0.00% 3 Missing ⚠️
...thfinding/components/Pathfinding/PathfindingV2.tsx 0.00% 2 Missing ⚠️
front/src/common/BootstrapSNCF/NavBarSNCF.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8042      +/-   ##
============================================
+ Coverage     28.13%   28.25%   +0.12%     
- Complexity     2120     2123       +3     
============================================
  Files          1302     1300       -2     
  Lines        158914   158376     -538     
  Branches       3179     3187       +8     
============================================
+ Hits          44715    44757      +42     
+ Misses       112293   111707     -586     
- Partials       1906     1912       +6     
Flag Coverage Δ
core 75.43% <ø> (+<0.01%) ⬆️
editoast 70.42% <ø> (+0.02%) ⬆️
front 10.02% <0.00%> (+0.05%) ⬆️
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch 18 times, most recently from f09eaea to bf26954 Compare July 19, 2024 15:47
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch 7 times, most recently from d13be43 to a242a05 Compare July 22, 2024 15:13
@Maymanaf Maymanaf marked this pull request as ready for review July 22, 2024 15:23
@Maymanaf Maymanaf requested a review from a team as a code owner July 22, 2024 15:23
@Maymanaf Maymanaf requested review from Yohh and clarani July 22, 2024 15:24
front/tests/pages/home-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/operational-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/operational-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/operational-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/operational-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/010-op-route-tab.spec.ts Outdated Show resolved Hide resolved
front/tests/010-op-route-tab.spec.ts Outdated Show resolved Hide resolved
front/tests/pages/operational-studies-page-model.ts Outdated Show resolved Hide resolved
front/tests/010-op-route-tab.spec.ts Outdated Show resolved Hide resolved
front/tests/010-op-route-tab.spec.ts Outdated Show resolved Hide resolved
front/tests/010-op-route-tab.spec.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch 3 times, most recently from 0d58750 to ffd2df3 Compare July 24, 2024 13:30
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Nice PR :)

Can you please squash your commits since they do not seem to be atomic ?

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch from ffd2df3 to 1cd672f Compare July 24, 2024 14:36
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch 5 times, most recently from 6a88576 to b1b7f85 Compare July 24, 2024 16:20
@Maymanaf Maymanaf force-pushed the aba/e2e-operational-studie-route branch from b1b7f85 to b1862de Compare July 25, 2024 10:02
@Maymanaf Maymanaf added this pull request to the merge queue Jul 25, 2024
Merged via the queue into dev with commit b003629 Jul 25, 2024
20 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-operational-studie-route branch July 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: add e2e tests operational studies - route
4 participants