fix(scripts): fail update-export-versions if snapshot update fails #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
update-export-versions.cjsscript was silently swallowing errors when snapshot updates failed. This caused:versions.tsto be updated to new version (e.g.,0.17.0)versions.tscommitted WITHOUT matching snapshots (which still have old version0.16.0)This is why PR #244 (Version Packages) keeps failing - the snapshots have
0.16.0whileversions.tshas0.17.0.Solution
The script now exits with code 1 if snapshot update fails, preventing the mismatched state from being committed.
Root Cause Analysis
Test plan
changeset-release/main