Skip to content

fix(scripts): fail update-export-versions if snapshot update fails #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasevin merged 1 commit into from
Nov 27, 2025
Merged

fix(scripts): fail update-export-versions if snapshot update fails #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions scripts/update-export-versions.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,15 @@ const updateVersionsFile = () => {
if (versionsUpdated) {
fs.writeFileSync(versionsFilePath, fileContent, 'utf8');
console.log('\n🎉 Successfully synchronized versions.ts!');

// Only update snapshots when versions actually changed
// This requires packages to be built, so we only do it when necessary
console.log('\n📸 Updating snapshots to match new versions...');
updateSnapshots();
} else {
console.log('\n✅ All versions in versions.ts are already up to date.');
console.log(' Skipping snapshot update (no version changes detected).');
}

// Always update snapshots to ensure they match current versions
console.log('\n📸 Ensuring snapshots match current versions...');
updateSnapshots();
};

const updateSnapshots = () => {
Expand All @@ -99,9 +101,14 @@ const updateSnapshots = () => {
console.log('✅ Snapshots updated successfully!');
} catch (error) {
console.error('❌ Failed to update snapshots:', error.message);
console.log(
'⚠️ Please run "pnpm --filter @openzeppelin/ui-builder-app test src/export/__tests__/ -- -u" manually'
console.error(
'⚠️ Snapshot update failed. This will cause CI failures if versions.ts is committed without matching snapshots.'
);
console.error(
' To fix manually, run: pnpm --filter @openzeppelin/ui-builder-app test src/export/__tests__/ -- -u'
);
// Exit with error code to prevent committing mismatched versions
process.exit(1);
}
};

Expand Down
Loading