feat(hepa-uv): Add a task to handle the UV Ballast state based on external input #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Jan 18, 2024
|
|
||
| // set the UV Ballast | ||
| if (door_closed && reed_switch_set && uv_push_button) { | ||
| gpio::set(drive_pins.uv_on_off); |
There was a problem hiding this comment.
what happens if i push the button twice?
There was a problem hiding this comment.
We toggle the uv_push_button every time it's pressed on line 61.
Assuming the ballast is on and the timer is running, pressing the button again would turn it off and cancel the timer.
sfoster1
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The HEPA/UV has a UV Ballast that needs to turn on/off based on external input, this pr adds a a task that actuates the UV ballast based on these external inputs. It also adds a timer that turns off the UV ballast after 15m.
Closes: RET-1402
Changes
Review Requests